Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757958Ab2EJJc7 (ORCPT ); Thu, 10 May 2012 05:32:59 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:55773 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757881Ab2EJJc5 convert rfc822-to-8bit (ORCPT ); Thu, 10 May 2012 05:32:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <1336136030-18503-1-git-send-email-benjamin.tissoires@gmail.com> <1336136030-18503-2-git-send-email-benjamin.tissoires@gmail.com> <20120506190146.GA12571@polaris.bitmath.org> <20120509195632.GA12406@polaris.bitmath.org> Date: Thu, 10 May 2012 11:32:56 +0200 Message-ID: Subject: Re: [PATCH 1/5] HID: hid-multitouch: fix wrong protocol detection From: Benjamin Tissoires To: Jiri Kosina Cc: Henrik Rydberg , Dmitry Torokhov , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 48 On Thu, May 10, 2012 at 10:31 AM, Jiri Kosina wrote: > On Wed, 9 May 2012, Henrik Rydberg wrote: > >> > well, the idea was to keep the memory footprint low. As these values >> > are only needed at init, then I freed them once I finished using them. >> > I can of course skip the pointer, but in that case, wouldn't the >> > struct declaration be worthless? >> >> My bad, I misread the placement of the free() statement. I was also >> concerned about memory, since HID is big enough a memory hog as it >> is. Barring the added complexity of this patch, it now makes more >> sense. >> >> ? ? Acked-by: Henrik Rydberg > > drivers/hid/hid-multitouch.c: In function ?mt_post_parse?: > drivers/hid/hid-multitouch.c:673: error: invalid type argument of ?->? (have ?unsigned int?) > make[1]: *** [drivers/hid/hid-multitouch.o] Error 1 > > I believe that > > ? ? ? ?td->last_slot_field = f->usages[field_count_per_touch - 1]->hid; > > should be > > ? ? ? ?td->last_slot_field = f->usages[field_count_per_touch - 1]; Ouch, indeed. the "->hid" is extra. When I split the patch 1 and 5, I missed that one. I tested it without the ->hid, and it's good. Do I need to resend the patch? Cheers, Benjamin > > but I leave this up to you guys to fix. > > Thanks, > > -- > Jiri Kosina > SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/