Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932253Ab2EJK4F (ORCPT ); Thu, 10 May 2012 06:56:05 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:60077 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932173Ab2EJKz7 convert rfc822-to-8bit (ORCPT ); Thu, 10 May 2012 06:55:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <1335935266-25289-1-git-send-email-thomas.abraham@linaro.org> <1335935266-25289-5-git-send-email-thomas.abraham@linaro.org> Date: Thu, 10 May 2012 16:25:59 +0530 Message-ID: Subject: Re: [PATCH 4/7] mmc: dw_mmc: add samsung exynos5250 specific extentions From: Thomas Abraham To: Olof Johansson Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, patches@linaro.org, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, grant.likely@secretlab.ca, kgene.kim@samsung.com, cjb@laptop.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2055 Lines: 49 On 2 May 2012 23:40, Olof Johansson wrote: > Hi, > > On Tue, May 1, 2012 at 10:07 PM, Thomas Abraham > wrote: >> The instantiation of the Synopsis Designware controller on Exynos5250 >> include extension for SDR and DDR specific tx/rx phase shift timing >> and CIU internal divider. In addition to that, the option to skip the >> command hold stage is also introduced. Add support for these Exynos5250 >> specfic extenstions. >> >> Signed-off-by: Abhilash Kesavan >> Signed-off-by: Thomas Abraham >> --- >> ?.../devicetree/bindings/mmc/synposis-dw-mshc.txt ? | ? 33 +++++++++++++++++++- >> ?drivers/mmc/host/dw_mmc-pltfm.c ? ? ? ? ? ? ? ? ? ?| ? ?8 +++++ >> ?drivers/mmc/host/dw_mmc.c ? ? ? ? ? ? ? ? ? ? ? ? ?| ? 32 ++++++++++++++++++- >> ?drivers/mmc/host/dw_mmc.h ? ? ? ? ? ? ? ? ? ? ? ? ?| ? 13 ++++++++ >> ?include/linux/mmc/dw_mmc.h ? ? ? ? ? ? ? ? ? ? ? ? | ? ?6 +++ >> ?5 files changed, 89 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt >> index c1ed70e..465fc31 100644 >> --- a/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt >> +++ b/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt >> @@ -7,6 +7,8 @@ Required Properties: >> >> ?* compatible: should be one of the following >> ? ? ? ?- synopsis,dw-mshc: for controllers compliant with synopsis dw-mshc. >> + ? ? ? - synopsis,dw-mshc-exynos5250: for controllers with Samsung >> + ? ? ? ? Exynos5250 specific extentions. > > It makes more sense to use your own manufacturer prefix here: > > samsung,exynos5250-dw-mshc > Ok. I will modify the compatible value as you have suggested. Thanks, Thomas. > > -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/