Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757822Ab2EJOZ4 (ORCPT ); Thu, 10 May 2012 10:25:56 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:35422 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755623Ab2EJOZw convert rfc822-to-8bit (ORCPT ); Thu, 10 May 2012 10:25:52 -0400 MIME-Version: 1.0 In-Reply-To: <1336658065-24851-3-git-send-email-mgorman@suse.de> References: <1336658065-24851-1-git-send-email-mgorman@suse.de> <1336658065-24851-3-git-send-email-mgorman@suse.de> Date: Thu, 10 May 2012 10:25:51 -0400 Message-ID: Subject: Re: [PATCH 02/12] selinux: tag avc cache alloc as non-critical From: Eric Paris To: Mel Gorman Cc: Andrew Morton , Linux-MM , Linux-Netdev , Linux-NFS , LKML , David Miller , Trond Myklebust , Neil Brown , Christoph Hellwig , Peter Zijlstra , Mike Christie , Eric B Munson Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1434 Lines: 40 On Thu, May 10, 2012 at 9:54 AM, Mel Gorman wrote: > Failing to allocate a cache entry will only harm performance not > correctness. ?Do not consume valuable reserve pages for something > like that. > > Signed-off-by: Peter Zijlstra > Signed-off-by: Mel Gorman Acked-by: Eric Paris > --- > ?security/selinux/avc.c | ? ?2 +- > ?1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/avc.c b/security/selinux/avc.c > index 8ee42b2..75c2977 100644 > --- a/security/selinux/avc.c > +++ b/security/selinux/avc.c > @@ -280,7 +280,7 @@ static struct avc_node *avc_alloc_node(void) > ?{ > ? ? ? ?struct avc_node *node; > > - ? ? ? node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC); > + ? ? ? node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC); > ? ? ? ?if (!node) > ? ? ? ? ? ? ? ?goto out; > > -- > 1.7.9.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at ?http://vger.kernel.org/majordomo-info.html > Please read the FAQ at ?http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/