Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760179Ab2EJPfP (ORCPT ); Thu, 10 May 2012 11:35:15 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:57473 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756229Ab2EJPfM (ORCPT ); Thu, 10 May 2012 11:35:12 -0400 Message-ID: <1336664102.15392.1.camel@phoenix> Subject: [PATCH] mfd: lm3533-core: Fix calling regmap_update_bits() with mask and val arguments swapped From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Johan Hovold , Mark Brown , Samuel Ortiz Date: Thu, 10 May 2012 23:35:02 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 31 Current code calls regmap_update_bits() with mask and val arguments swapped. Fix it. Signed-off-by: Axel Lin --- drivers/mfd/lm3533-core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c index 75f4b7f..4a006c2 100644 --- a/drivers/mfd/lm3533-core.c +++ b/drivers/mfd/lm3533-core.c @@ -128,7 +128,7 @@ int lm3533_update(struct lm3533 *lm3533, u8 reg, u8 val, u8 mask) dev_dbg(lm3533->dev, "update [%02x]: %02x/%02x\n", reg, val, mask); - ret = regmap_update_bits(lm3533->regmap, reg, val, mask); + ret = regmap_update_bits(lm3533->regmap, reg, mask, val); if (ret < 0) { dev_err(lm3533->dev, "failed to update register %02x: %d\n", reg, ret); -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/