Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932069Ab2EJUxE (ORCPT ); Thu, 10 May 2012 16:53:04 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:59439 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757062Ab2EJUxB (ORCPT ); Thu, 10 May 2012 16:53:01 -0400 MIME-Version: 1.0 In-Reply-To: <1336682772.29763.6.camel@joe2Laptop> References: <20120509070710.GA29981@gmail.com> <1336611278.728.9.camel@mop> <1336667984.947.24.camel@mop> <1336676986.947.47.camel@mop> <20120510201409.GA6467@thunk.org> <1336682226.29763.2.camel@joe2Laptop> <1336682772.29763.6.camel@joe2Laptop> From: Linus Torvalds Date: Thu, 10 May 2012 13:52:39 -0700 X-Google-Sender-Auth: KKafajoijUsGgbprNIcNDXNep3Y Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Joe Perches Cc: Kay Sievers , "Ted Ts'o" , Ingo Molnar , Jonathan Corbet , Sasha Levin , Greg Kroah-Hartmann , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 29 On Thu, May 10, 2012 at 1:46 PM, Joe Perches wrote: > > That's where I think you're still a bit > uncertain how the _current_ printk system > works. No, you are. Read my answer from two days ago in this thread. KERN_CONT is *not* the same as "". Not now, not ever. If you make it the same, you're broken. The reason is simple: KERN_CONT "<3>" should print out the string "<3>". If you make KERN_CONT be "", it will do the wrong thing, and think that the <3> is a priority marker. Please people, this is subtle, and current code does things RIGHT. Any code that changes it to do something else is almost certainly buggy. The new semantics had better be the same as the old one. The change to verify that 'current' matches the previous printout is so far the *only* sane semantic change I've seen in this thread. Everything else has been pure garbage. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/