Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761718Ab2EJV6d (ORCPT ); Thu, 10 May 2012 17:58:33 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:45286 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761648Ab2EJV6a (ORCPT ); Thu, 10 May 2012 17:58:30 -0400 MIME-Version: 1.0 In-Reply-To: <1336684277.29763.12.camel@joe2Laptop> References: <20120509070710.GA29981@gmail.com> <1336611278.728.9.camel@mop> <1336667984.947.24.camel@mop> <1336676986.947.47.camel@mop> <20120510201409.GA6467@thunk.org> <1336682226.29763.2.camel@joe2Laptop> <1336682772.29763.6.camel@joe2Laptop> <1336684277.29763.12.camel@joe2Laptop> From: Linus Torvalds Date: Thu, 10 May 2012 14:58:08 -0700 X-Google-Sender-Auth: pLZdXENju7qkuRXQD2ViFZRvqag Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Joe Perches Cc: Kay Sievers , "Ted Ts'o" , Ingo Molnar , Jonathan Corbet , Sasha Levin , Greg Kroah-Hartmann , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 994 Lines: 27 On Thu, May 10, 2012 at 2:11 PM, Joe Perches wrote: > > I think it's a distinction without a difference for, > as fas as I know, that's a case that doesn't exist > in the current kernel. So? Even if we hadn't had this bug before (we have), your argument is utter crap. Even if we weren't to have that patter right *now*, that doesn't mean that it cannot happen. Your grep is also not at all exhaustive. What if somebody does printk("%s.." how are you going to prove that '%s' doesn't contain a level marker thing? It's much easier to just say "use a KERN_CONT" (or more commonly KERN_DEFAULT) to avoid the problem. We do need an escape model. The current KERN_CONT does that. Stop arguing for crap. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/