Subject: Re: [PATCH] dmaengine: dw_dma: add Device Tree probing capability
From: Vinod Koul <vinod.koul@linux.intel.com>
To: Viresh Kumar <viresh.linux@gmail.com>
Cc: spear-devel@list.st.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Viresh Kumar <viresh.kumar@st.com>
In-Reply-To: <35e64128140409833be8ca543b9640c2dac39796.1334933079.git.viresh.kumar@st.com>
References: <35e64128140409833be8ca543b9640c2dac39796.1334933079.git.viresh.kumar@st.com>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 11 May 2012 10:47:10 +0530
Message-ID: <1336713430.15424.1511.camel@vkoul-udesk3>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2561
Lines: 80

On Fri, 2012-04-20 at 20:15 +0530, Viresh Kumar wrote:
> SPEAr platforms now support DT and so must convert all drivers to support DT.
> This patch adds DT probing support for Synopsys DMA controller and updates its
> documentation too.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
Applied, Thanks
> ---
>  Documentation/devicetree/bindings/dma/snps-dma.txt |   17 +++++++++++++++++
>  drivers/dma/dw_dmac.c                              |   10 ++++++++++
>  2 files changed, 27 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/dma/snps-dma.txt
> 
> diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt b/Documentation/devicetree/bindings/dma/snps-dma.txt
> new file mode 100644
> index 0000000..c0d85db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/snps-dma.txt
> @@ -0,0 +1,17 @@
> +* Synopsys Designware DMA Controller
> +
> +Required properties:
> +- compatible: "snps,dma-spear1340"
> +- reg: Address range of the DMAC registers
> +- interrupt-parent: Should be the phandle for the interrupt controller
> +  that services interrupts for this device
> +- interrupt: Should contain the DMAC interrupt number
> +
> +Example:
> +
> +	dma@fc000000 {
> +		compatible = "snps,dma-spear1340";
> +		reg = <0xfc000000 0x1000>;
> +		interrupt-parent = <&vic1>;
> +		interrupts = <12>;
> +	};
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index 300d976..13b9298 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -17,6 +17,7 @@
>  #include <linux/init.h>
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
> +#include <linux/of.h>
>  #include <linux/mm.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> @@ -1592,12 +1593,21 @@ static const struct dev_pm_ops dw_dev_pm_ops = {
>  	.poweroff_noirq = dw_suspend_noirq,
>  };
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id dw_dma_id_table[] = {
> +	{ .compatible = "snps,dma-spear1340" },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(of, dw_dma_id_table);
> +#endif
> +
>  static struct platform_driver dw_driver = {
>  	.remove		= __exit_p(dw_remove),
>  	.shutdown	= dw_shutdown,
>  	.driver = {
>  		.name	= "dw_dmac",
>  		.pm	= &dw_dev_pm_ops,
> +		.of_match_table = of_match_ptr(dw_dma_id_table),
>  	},
>  };
>  


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/