Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756974Ab2EKKfa (ORCPT ); Fri, 11 May 2012 06:35:30 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:37603 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887Ab2EKKf3 (ORCPT ); Fri, 11 May 2012 06:35:29 -0400 MIME-Version: 1.0 In-Reply-To: <1336617045.25027.2.camel@mop> References: <1336004953.4240.9.camel@mop> <1336475689.1179.12.camel@mop> <1336571457.30189.29.camel@joe2Laptop> <20120509230649.GA10695@kroah.com> <1336617045.25027.2.camel@mop> From: Sasha Levin Date: Fri, 11 May 2012 12:35:07 +0200 Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Kay Sievers Cc: Greg Kroah-Hartmann , Yinghai Lu , Joe Perches , Linus Torvalds , Ingo Molnar , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1624 Lines: 48 On Thu, May 10, 2012 at 4:30 AM, Kay Sievers wrote: > On Wed, 2012-05-09 at 16:06 -0700, Greg Kroah-Hartmann wrote: >> On Wed, May 09, 2012 at 04:02:40PM -0700, Yinghai Lu wrote: >> > On Wed, May 9, 2012 at 7:37 AM, Kay Sievers wrote: >> > > >> > >> Changing printk semantics and trying to stabilize >> > >> printk message content are bad ideas though. >> > > >> > > Again, nobody talks about content of here. >> > >> > printk_time=1 does not work anymore with this patch on serial console. >> >> Known issue, I think Kay is working on the solution for this right >> now... > > Sure, and this seems to work for me. > > Thanks, > Kay > > > From: Kay Sievers > Subject: printk() - restore timestamp printing at console output > > The output of the timestamps got lost with the conversion of the > kmsg buffer to records; restore the old behavior. > > Document, that CONFIG_PRINTK_TIME now only controls the output of > the timestamps in the syslog() system call and on the console, and > not the recording of the timestamps. > > Signed-off-by: Kay Sievers > --- This has a small issue with the way timing is printed compared to how it worked previously. Consider the following case: printk("\n foo \n bar \n zoot") Previously, you would see timing on each line of the print, but now you see it only on the first. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/