Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759825Ab2EKN3x (ORCPT ); Fri, 11 May 2012 09:29:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30406 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753500Ab2EKN3v convert rfc822-to-8bit (ORCPT ); Fri, 11 May 2012 09:29:51 -0400 From: Jeff Moyer To: Kent Overstreet Cc: Vivek Goyal , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, tejun@google.com, agk@redhat.com, Martin Peterson Subject: Re: [dm-devel] [Bcache v13 01/16] Only clone bio vecs that are in use References: <20120510213556.GO23768@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 11 May 2012 09:29:42 -0400 In-Reply-To: (Kent Overstreet's message of "Thu, 10 May 2012 14:42:17 -0700") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 39 [top posting fixed] Kent Overstreet writes: > 2012/5/10 Vivek Goyal : >> On Wed, May 09, 2012 at 11:08:13PM -0400, Kent Overstreet wrote: >> >> [..] >>> - >>> -     if (bio_integrity(bio)) { >>> -             bio_integrity_clone(clone, bio, GFP_NOIO, bs); >>> - >>> +#if 0 >>> +     if (bio_integrity(bio)) >>>               if (idx != bio->bi_idx || clone->bi_size < bio->bi_size) >>>                       bio_integrity_trim(clone, >>>                                          bio_sector_offset(bio, idx, 0), len); >>> -     } >>> - >>> +#endif >> >> Dead/debug code under "#if 0" ? >> > Oh, I never got around to figuring out what needed to be done with the > bio integrity - presumably it'll have to be handled differently > somehow (I'm assuming an index in the integrity bvec is intended to > match up with an index in the regular bvec), but I don't have any way > to test the integrity stuff. The scsi debug module supports dif/dix, so you can use that for testing. Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/