Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759518Ab2EKPWz (ORCPT ); Fri, 11 May 2012 11:22:55 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:65408 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753729Ab2EKPWy convert rfc822-to-8bit (ORCPT ); Fri, 11 May 2012 11:22:54 -0400 MIME-Version: 1.0 In-Reply-To: <20120511151944.GA6990@kroah.com> References: <1336475689.1179.12.camel@mop> <1336571457.30189.29.camel@joe2Laptop> <20120509230649.GA10695@kroah.com> <1336617045.25027.2.camel@mop> <20120511151944.GA6990@kroah.com> From: Sasha Levin Date: Fri, 11 May 2012 17:22:32 +0200 Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Greg KH Cc: Kay Sievers , Yinghai Lu , Joe Perches , Linus Torvalds , Ingo Molnar , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 27 On Fri, May 11, 2012 at 5:19 PM, Greg KH wrote: > On Fri, May 11, 2012 at 12:35:07PM +0200, Sasha Levin wrote: >> This has a small issue with the way timing is printed compared to how >> it worked previously. >> >> Consider the following case: >> >> ? ? printk("\n foo \n bar \n zoot") >> >> Previously, you would see timing on each line of the print, but now >> you see it only on the first. > > What code does this? ?Shouldn't those be individual printk lines? ?I > didn't think that type of line would ever work properly in the past. At least the lockdep code, in several places: __print_lock_name(safe_class); printk(");\n"); printk("\n *** DEADLOCK ***\n\n"); Which has looked fine before. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/