Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757758Ab2EKPlO (ORCPT ); Fri, 11 May 2012 11:41:14 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:55239 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040Ab2EKPlM convert rfc822-to-8bit (ORCPT ); Fri, 11 May 2012 11:41:12 -0400 MIME-Version: 1.0 In-Reply-To: References: <1336475689.1179.12.camel@mop> <1336571457.30189.29.camel@joe2Laptop> <20120509230649.GA10695@kroah.com> <1336617045.25027.2.camel@mop> <20120511151944.GA6990@kroah.com> From: Kay Sievers Date: Fri, 11 May 2012 17:40:51 +0200 Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Linus Torvalds Cc: Greg KH , Sasha Levin , Yinghai Lu , Joe Perches , Ingo Molnar , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 27 On Fri, May 11, 2012 at 5:35 PM, Linus Torvalds wrote: > On Fri, May 11, 2012 at 8:19 AM, Greg KH wrote: >> >> What code does this?  Shouldn't those be individual printk lines?  I >> didn't think that type of line would ever work properly in the past. > > We've *always* supported multiple lines, Greg. And it has always > worked. It's very inconvenient to have to use multiple printk's when > one would do. > > That said, I think it would be interesting if the timing values were > just not printed at all when they match the last one, which would > happen with this kind of setup (and also happens if your time source > sucks). > > You'd still want the lines to line up, though. Should we just pad the multi-newline-in-one-record output with 15 spaces when printk_time is on? Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/