Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960Ab2EMGxS (ORCPT ); Sun, 13 May 2012 02:53:18 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:45618 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547Ab2EMGxR convert rfc822-to-8bit (ORCPT ); Sun, 13 May 2012 02:53:17 -0400 MIME-Version: 1.0 X-Originating-IP: [212.179.42.66] In-Reply-To: References: <201205111008157652383@gmail.com> Date: Sun, 13 May 2012 09:53:15 +0300 Message-ID: Subject: Re: [PATCH] slub: missing test for partial pages flush work in flush_all From: Gilad Ben-Yossef To: Christoph Lameter Cc: majianpeng , linux-mm , Pekka Enberg , linux-kernel@vger.kernel.org, Andrew Morton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3840 Lines: 103 On Fri, May 11, 2012 at 7:14 PM, Christoph Lameter wrote: > Didn't I already ack this before? > > Acked-by: Christoph Lameter > Yes, you did, but the patch description and title was lacking and Majianpeng kindly fixed it, hence the re-send, I guess. I've added Andrew, since he took my original commit that introduces the bug that this patch by Majianpeng fixes (and also LKML). This fix really needs to get into 3.4, otherwise we'll be breaking slub. What's the best way to go about that? Thanks! Gilad > On Fri, 11 May 2012, majianpeng wrote: > >> Subject: [PATCH] slub: missing test for partial pages flush work in flush_all >> >> Find some kernel message like: >> SLUB raid5-md127: kmem_cache_destroy called for cache that still has objects. >> Pid: 6143, comm: mdadm Tainted: G ? ? ? ? ? O 3.4.0-rc6+ ? ? ? ?#75 >> Call Trace: >> [] kmem_cache_destroy+0x328/0x400 >> [] free_conf+0x2d/0xf0 [raid456] >> [] stop+0x41/0x60 [raid456] >> [] md_stop+0x1a/0x60 [md_mod] >> [] do_md_stop+0x74/0x470 [md_mod] >> [] md_ioctl+0xff/0x11f0 [md_mod] >> [] blkdev_ioctl+0xd8/0x7a0 >> [] block_ioctl+0x3b/0x40 >> [] do_vfs_ioctl+0x96/0x560 >> [] sys_ioctl+0x91/0xa0 >> [] system_call_fastpath+0x16/0x1b >> >> Then using kmemleak can found those messages: >> unreferenced object 0xffff8800b6db7380 (size 112): >> ? comm "mdadm", pid 5783, jiffies 4294810749 (age 90.589s) >> ? hex dump (first 32 bytes): >> ? ? 01 01 db b6 ad 4e ad de ff ff ff ff ff ff ff ff ?.....N.......... >> ? ? ff ff ff ff ff ff ff ff 98 40 4a 82 ff ff ff ff ?.........@J..... >> ? backtrace: >> ? ? [] kmemleak_alloc+0x21/0x50 >> ? ? [] kmem_cache_alloc+0xeb/0x1b0 >> ? ? [] kmem_cache_open+0x2f1/0x430 >> ? ? [] kmem_cache_create+0x158/0x320 >> ? ? [] setup_conf+0x649/0x770 [raid456] >> ? ? [] run+0x68b/0x840 [raid456] >> ? ? [] md_run+0x529/0x940 [md_mod] >> ? ? [] do_md_run+0x18/0xc0 [md_mod] >> ? ? [] md_ioctl+0xba8/0x11f0 [md_mod] >> ? ? [] blkdev_ioctl+0xd8/0x7a0 >> ? ? [] block_ioctl+0x3b/0x40 >> ? ? [] do_vfs_ioctl+0x96/0x560 >> ? ? [] sys_ioctl+0x91/0xa0 >> ? ? [] system_call_fastpath+0x16/0x1b >> ? ? [] 0xffffffffffffffff >> >> This bug introduced by Commit a8364d5555b2030d093cde0f0795.The >> commit did not include checks for per cpu partial pages being present on a >> cpu. >> >> Signed-off-by: majianpeng >> --- >> ?mm/slub.c | ? ?2 +- >> ?1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/mm/slub.c b/mm/slub.c >> index ffe13fd..6fce08f 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -2040,7 +2040,7 @@ static bool has_cpu_slab(int cpu, void *info) >> ? ? ? struct kmem_cache *s = info; >> ? ? ? struct kmem_cache_cpu *c = per_cpu_ptr(s->cpu_slab, cpu); >> >> - ? ? return !!(c->page); >> + ? ? return c->page || c->partial; >> ?} >> >> ?static void flush_all(struct kmem_cache *s) >> -- Gilad Ben-Yossef Chief Coffee Drinker gilad@benyossef.com Israel Cell: +972-52-8260388 US Cell: +1-973-8260388 http://benyossef.com "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" ?-- Jean-Baptiste Queru -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/