Date: Sun, 13 May 2012 13:45:03 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Christoph Lameter <cl@linux.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Rob Landley <rob@landley.net>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        Arnd Bergmann <arnd@arndb.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Howells <dhowells@redhat.com>,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Herbert Xu <herbert@gondor.hengli.com.au>,
        Stephen Rothwell <sfr@canb.auug.org.au>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        Gleb Natapov <gleb@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
        kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCHv2] bitops: add _local bitops
Message-ID: <20120513104502.GD23273@redhat.com>
References: <20120509162819.GA21328@redhat.com>
 <alpine.DEB.2.00.1205101401010.18664@router.home>
 <4FAF8941.2010308@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FAF8941.2010308@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1651
Lines: 40

On Sun, May 13, 2012 at 01:13:21PM +0300, Avi Kivity wrote:
> On 05/10/2012 10:04 PM, Christoph Lameter wrote:
> > On Wed, 9 May 2012, Michael S. Tsirkin wrote:
> >
> > > kvm needs to update some hypervisor variables atomically
> > > in a sense that the operation can't be interrupted
> > > in the middle. However the hypervisor always runs
> > > on the same CPU so it does not need any memory
> > > barrier or lock prefix.
> > >
> > > Add _local bitops for this purpose: define them
> > > as non-atomics for x86 and (for now) atomics for
> > > everyone else.
> >
> > Have you tried to use the this_cpu_ops for that purpose? They create the
> > per cpu atomic instructions that you want without a lock prefix and can
> > also relocate the per cpu pointer to the correct processor via a
> > segment register prefix.
> >
> > There are no bit operations provided right now but those can either be
> > improvised using this_cpu_cmpxchg or added.
> 
> this_cpu_xchg() should be sufficient, since only bit zero has any
> meaning in our use case (so xchg with zero is equivalent to
> test_and_clear_bit).

Yes it should work. No idea how it'd perform:
arch/x86/include/asm/percpu.h implies it's expensive.  My latest version
simply documents what __test_and_clear does anyway.
Which was indicated is acceptable ...
Did you change your mind?

> 
> -- 
> error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/