Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755917Ab2ENLNb (ORCPT ); Mon, 14 May 2012 07:13:31 -0400 Received: from casper.infradead.org ([85.118.1.10]:54467 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755465Ab2ENLNa convert rfc822-to-8bit (ORCPT ); Mon, 14 May 2012 07:13:30 -0400 Message-ID: <1336994000.2443.24.camel@twins> Subject: Re: [GIT PULL 0/8] Annotation weekly ponies delivery From: Peter Zijlstra To: Linus Torvalds Cc: Arnaldo Carvalho de Melo , Ingo Molnar , linux-kernel@vger.kernel.org, Arjan van de Ven , David Ahern , Frederic Weisbecker , Mike Galbraith , Namhyung Kim , Paul Mackerras , Stephane Eranian , arnaldo.melo@gmail.com, Arnaldo Carvalho de Melo Date: Mon, 14 May 2012 13:13:20 +0200 In-Reply-To: References: <1336852387-16322-1-git-send-email-acme@infradead.org> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2629 Lines: 67 On Sat, 2012-05-12 at 13:40 -0700, Linus Torvalds wrote: > The whole "-e cycles:pp" doesn't work any more. I don't get any nice > PEBS information, I get the totally useless irq-based profiling. > > The difference for a "make -j" profile is quite stunning: > > Doing "perf record -f -e cycles:pp -F 20000 make -j" > > - my current git: > > [ perf record: Woken up 47 times to write data ] > [ perf record: Captured and wrote 11.890 MB perf.data (~519462 samples) ] > > - with the above tree pulled into my current git tree (but compiling > the same old tree): > > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.031 MB perf.data (~1375 samples) ] The output simply suggests we're not getting enough samples not that PEBS isn't working, in fact I can could reproduce without using PEBS. This bisected to the below commit, the code has since been changed again and all that evlist stuff gives me a head-ache. Acme, Namhyung ? 55261f46702cec96911a81aacfb3cba13434d304 is the first bad commit commit 55261f46702cec96911a81aacfb3cba13434d304 Author: Namhyung Kim Date: Mon May 7 14:08:59 2012 +0900 perf evlist: Fix creation of cpu map Currently, 'perf record -- sleep 1' creates a cpu map for all online cpus since it turns out calling cpu_map__new(NULL). Fix it. Also it is guaranteed that cpu_list is NULL if PID/TID is given by calling perf_target__validate(), so we can make the conditional bit simpler. This also fixes perf test 7 (Validate) failure on my 6 core machine: $ cat /sys/devices/system/cpu/online 0-11 $ ./perf test -v 7 7: Validate PERF_RECORD_* events & perf_sample fields: --- start --- perf_evlist__mmap: Operation not permitted ---- end ---- Validate PERF_RECORD_* events & perf_sample fields: FAILED! Signed-off-by: Namhyung Kim Reviewed-by: David Ahern Cc: David Ahern Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1336367344-28071-3-git-send-email-namhyung.kim@lge.com Signed-off-by: Arnaldo Carvalho de Melo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/