Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756852Ab2ENQLl (ORCPT ); Mon, 14 May 2012 12:11:41 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:61584 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756488Ab2ENQLj convert rfc822-to-8bit (ORCPT ); Mon, 14 May 2012 12:11:39 -0400 MIME-Version: 1.0 X-Originating-IP: [116.14.117.25] In-Reply-To: <1336058460-19924-1-git-send-email-daniel@quora.org> References: <1336058460-19924-1-git-send-email-daniel@quora.org> Date: Tue, 15 May 2012 00:11:37 +0800 Message-ID: Subject: Re: [PATCH] Prevent interface errors with Seagate FreeAgent GoFlex From: Daniel J Blueman To: Jeff Garzik Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Mokrejs Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2185 Lines: 56 Jeff, On 3 May 2012 23:21, Daniel J Blueman wrote: > When connected by the optional eSATAp cable, various interface errors > occur with my new external Seagate FreeAgent GoFlex (firmware 0110) until > the interface is forced to 1.5Gbps mode. Blacklist 3.0Gbps mode with it > to avoid the error messages, delays and dataloss potential. > > Signed-off-by: Daniel J Blueman > --- > ?drivers/ata/libata-core.c | ? ?1 + > ?1 file changed, 1 insertion(+) > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 28db50b..0781510 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -4119,6 +4119,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { > > ? ? ? ?/* Devices which aren't very happy with higher link speeds */ > ? ? ? ?{ "WD My Book", ? ? ? ? ? ? ? ? NULL, ? ATA_HORKAGE_1_5_GBPS, }, > + ? ? ? { "Seagate FreeAgent GoFlex", ? NULL, ? ATA_HORKAGE_1_5_GBPS, }, > > ? ? ? ?/* > ? ? ? ? * Devices which choke on SETXFER. ?Applies only if both the I addressed concerns Martin raised; any further objections to taking this patch? I still see issues and potential data loss after a short while until the link has negotiated down to 1.5Gb/s [1] without it, and no issues with the patch applied. Thanks, Daniel --- [1] ata5.00: exception Emask 0x52 SAct 0x0 SErr 0x1400c01 action 0x6 frozen ata5.00: irq_stat 0x0c000000, interface fatal error ata5: SError: { RecovData Proto HostInt Handshk TrStaTrns } ata5.00: failed command: READ DMA ata5.00: cmd c8/00:01:00:00:00/00:00:00:00:00/e0 tag 0 dma 512 in res 50/00:00:00:4f:c2/00:00:00:00:00/40 Emask 0x52 (ATA bus error) ata5.00: status: { DRDY } ata5: hard resetting link ata5: SATA link down (SStatus 1 SControl 300) ata5: hard resetting link ata5: SATA link up 1.5 Gbps (SStatus 113 SControl 300) ata5.00: configured for UDMA/133 ata5: EH complete -- Daniel J Blueman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/