Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723Ab2ENQjT (ORCPT ); Mon, 14 May 2012 12:39:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45899 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376Ab2ENQjS (ORCPT ); Mon, 14 May 2012 12:39:18 -0400 Date: Mon, 14 May 2012 18:39:16 +0200 From: Michal Hocko To: Hugh Dickins Cc: Andrew Morton , Konstantin Khlebnikov , KAMEZAWA Hiroyuki , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm/memcg: apply add/del_page to lruvec Message-ID: <20120514163916.GD22629@tiehlicka.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 44 On Sun 13-05-12 22:02:28, Hugh Dickins wrote: > Take lruvec further: pass it instead of zone to add_page_to_lru_list() > and del_page_from_lru_list(); and pagevec_lru_move_fn() pass lruvec > down to its target functions. > > This cleanup eliminates a swathe of cruft in memcontrol.c, > including mem_cgroup_lru_add_list(), mem_cgroup_lru_del_list() and > mem_cgroup_lru_move_lists() - which never actually touched the lists. Yes add_page_to_lru_list vs. mem_cgroup_lru_add_list and del variant were really confusing. > In their place, mem_cgroup_page_lruvec() to decide the lruvec, > previously a side-effect of add, and mem_cgroup_update_lru_size() > to maintain the lru_size stats. > > Whilst these are simplifications in their own right, the goal is to > bring the evaluation of lruvec next to the spin_locking of the lrus, > in preparation for a future patch. > > Signed-off-by: Hugh Dickins I like the patch but if Konstantin has a split up version of the same thing I would rather see that version first. > --- > The horror, the horror: I have three lines of 81 columns: > I do think they look better this way than split up. Agreed. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/