Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755692Ab2ENQqb (ORCPT ); Mon, 14 May 2012 12:46:31 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:53337 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752901Ab2ENQqa (ORCPT ); Mon, 14 May 2012 12:46:30 -0400 Message-ID: <1337013987.29436.16.camel@joe2Laptop> Subject: Re: [PATCH 1/1] printk: Make it compile with !CONFIG_PRINTK From: Joe Perches To: Kay Sievers Cc: Hiroshi DOYU , linux-tegra@vger.kernel.org, Peter Zijlstra , Andrew Morton , Ingo Molnar , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Date: Mon, 14 May 2012 09:46:27 -0700 In-Reply-To: References: <1337012284-18680-1-git-send-email-hdoyu@nvidia.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 34 On Mon, 2012-05-14 at 18:20 +0200, Kay Sievers wrote: > On Mon, May 14, 2012 at 6:18 PM, Hiroshi DOYU wrote: > > Add missing prepend_timestamp() dummy. > > That was fixed already last week: > http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=commitdiff;h=1fce677971e29ceaa7c569741fa9c685a7b1052a Yup, but in my opinion, this particular fix shouldn't be necessary because the CONFIG_PRINTK bits should have better code separation. None of the code that calls prepend_timestamp should actually be compiled in when !CONFIG_PRINTK. The same is true for unnecessary uses like the existing per-cpu: static DEFINE_PER_CPU(int, printk_pending); static DEFINE_PER_CPU(char [PRINTK_BUF_SIZE], printk_sched_buf); After this patchset is accepted into mainline, I'll revive the modularization and move of kernel/printk.c and associated files into -> kernel/printk/* patch I did awhile ago. I'll follow-on to this message with the original patches just as an fyi/rfc. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/