Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757321Ab2ENQyy (ORCPT ); Mon, 14 May 2012 12:54:54 -0400 Received: from mail.vyatta.com ([76.74.103.46]:45651 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757251Ab2ENQyt (ORCPT ); Mon, 14 May 2012 12:54:49 -0400 Date: Mon, 14 May 2012 09:54:46 -0700 From: Stephen Hemminger To: "Michael S. Tsirkin" Cc: "David S. Miller" , Joe Perches , Jason Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ian.Campbell@citrix.com, kvm@vger.kernel.org Subject: Re: [PATCH RFC] tun: experimental zero copy tx support Message-ID: <20120514095446.3ce307d2@nehalam.linuxnetplumber.net> In-Reply-To: <20120513155206.GA26847@redhat.com> References: <20120513155206.GA26847@redhat.com> Organization: Vyatta X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 15 On Sun, 13 May 2012 18:52:06 +0300 "Michael S. Tsirkin" wrote: > + /* Userspace may produce vectors with count greater than > + * MAX_SKB_FRAGS, so we need to linearize parts of the skb > + * to let the rest of data to be fit in the frags. > + */ Rather than complex partial code, just go through slow path for requests with too many frags (or for really small requests). Creating mixed skb's seems too easy to get wrong. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/