Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757325Ab2ENRET (ORCPT ); Mon, 14 May 2012 13:04:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55296 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756750Ab2ENRES (ORCPT ); Mon, 14 May 2012 13:04:18 -0400 Date: Mon, 14 May 2012 20:04:13 +0300 From: "Michael S. Tsirkin" To: Stephen Hemminger Cc: "David S. Miller" , Joe Perches , Jason Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ian.Campbell@citrix.com, kvm@vger.kernel.org Subject: Re: [PATCH RFC] tun: experimental zero copy tx support Message-ID: <20120514170412.GA17086@redhat.com> References: <20120513155206.GA26847@redhat.com> <20120514095446.3ce307d2@nehalam.linuxnetplumber.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120514095446.3ce307d2@nehalam.linuxnetplumber.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 879 Lines: 22 On Mon, May 14, 2012 at 09:54:46AM -0700, Stephen Hemminger wrote: > On Sun, 13 May 2012 18:52:06 +0300 > "Michael S. Tsirkin" wrote: > > > + /* Userspace may produce vectors with count greater than > > + * MAX_SKB_FRAGS, so we need to linearize parts of the skb > > + * to let the rest of data to be fit in the frags. > > + */ > Rather than complex partial code, just go through slow path for > requests with too many frags (or for really small requests). > Creating mixed skb's seems too easy to get wrong. I don't object in principle but macvtap has same code so seems better to stay consistent. -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/