Date: Mon, 14 May 2012 13:53:27 -0500 (CDT)
From: Christoph Lameter <cl@linux.com>
To: Pravin B Shelar <pshelar@nicira.com>
cc: penberg@kernel.org, mpm@selenic.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, jesse@nicira.com, abhide@nicira.com
Subject: Re: [PATCH 1/2] mm: Fix slab->page flags corruption.
In-Reply-To: <1337020877-20087-1-git-send-email-pshelar@nicira.com>
Message-ID: <alpine.DEB.2.00.1205141352440.26304@router.home>
References: <1337020877-20087-1-git-send-email-pshelar@nicira.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 799
Lines: 19

On Mon, 14 May 2012, Pravin B Shelar wrote:

> Transparent huge pages can change page->flags (PG_compound_lock)
> without taking Slab lock. Since THP can not break slab pages we can
> safely access compound page without taking compound lock.
>
> Specificly this patch fixes race between compound_unlock and slab
> functions which does page-flags update. This can occur when
> get_page/put_page is called on page from slab object.

You need to also get this revbiewed by the THP folks like Andrea &
friends.

Reviewed-by: Christoph Lameter <cl@linux.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/