Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932407Ab2ENVWA (ORCPT ); Mon, 14 May 2012 17:22:00 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:59491 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932282Ab2ENVV7 (ORCPT ); Mon, 14 May 2012 17:21:59 -0400 Date: Mon, 14 May 2012 17:20:54 -0400 (EDT) Message-Id: <20120514.172054.1808957948842230657.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: levinsasha928@gmail.com, edumazet@google.com, dave.taht@bufferbloat.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: codel: fix build errors From: David Miller In-Reply-To: <1337029683.8512.626.camel@edumazet-glaptop> References: <1337015687-17693-1-git-send-email-levinsasha928@gmail.com> <1337029683.8512.626.camel@edumazet-glaptop> X-Mailer: Mew version 6.5 on Emacs 24.0.95 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Mon, 14 May 2012 14:20:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 509 Lines: 14 From: Eric Dumazet Date: Mon, 14 May 2012 23:08:03 +0200 > Anonymous unions are fine, we use them a lot in kernel. > > Please fix the initializers instead in fq_codel_dump_stats(), because > these two #define are not very nice. Agreed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/