Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932440Ab2ENVeZ (ORCPT ); Mon, 14 May 2012 17:34:25 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:60920 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932268Ab2ENVeU convert rfc822-to-8bit (ORCPT ); Mon, 14 May 2012 17:34:20 -0400 MIME-Version: 1.0 In-Reply-To: <20120512001818.GH14782@lizard> References: <20120512001506.GA8653@lizard> <20120512001818.GH14782@lizard> Date: Mon, 14 May 2012 14:34:18 -0700 X-Google-Sender-Auth: gQLX-V7DrLogSflOQhGwCPrRf48 Message-ID: Subject: Re: [PATCH 08/11] ramoops: Move to fs/pstore/ram.c From: Kees Cook To: Anton Vorontsov Cc: Greg Kroah-Hartman , Colin Cross , Arnd Bergmann , John Stultz , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 48 On Fri, May 11, 2012 at 5:18 PM, Anton Vorontsov wrote: > Since ramoops was converted to pstore, it has nothing to do with character > devices nowadays. Instead, today it is just a RAM backend for pstore. > > The patch just moves things around. There are a few changes were needed > because of the move: > > 1. Kconfig and Makefiles fixups, of course. > > 2. In pstore/ram.c we have to play a bit with MODULE_PARAM_PREFIX, this > ? is needed to keep user experience the same as with ramoops driver > ? (i.e. so that ramoops.foo kernel command line arguments would still > ? work). > > Signed-off-by: Anton Vorontsov This consolidation seems good. I might prefer the move separated from the changes, just to make review easier, but I have no idea what that'll do to a bisect. :P > --- /dev/null > +++ b/fs/pstore/ram.c "ram.ko" seems like an awfully generic modbule name. Should this be called pstore_ram.* instead, like was done for the header file? And unless anyone objects, I have no problem letting the built-in name change too. > --- /dev/null > +++ b/include/linux/pstore_ram.h > @@ -0,0 +1,17 @@ > +#ifndef __RAMOOPS_H > +#define __RAMOOPS_H This define should probably change just to avoid confusion. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/