Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932479Ab2ENVtT (ORCPT ); Mon, 14 May 2012 17:49:19 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:55033 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234Ab2ENVtR (ORCPT ); Mon, 14 May 2012 17:49:17 -0400 Subject: Re: [PATCH] net: codel: fix build errors From: Eric Dumazet To: Sasha Levin Cc: edumazet@google.com, dave.taht@bufferbloat.net, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: References: <1337015687-17693-1-git-send-email-levinsasha928@gmail.com> <1337029683.8512.626.camel@edumazet-glaptop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 14 May 2012 23:49:12 +0200 Message-ID: <1337032152.8512.638.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 38 On Mon, 2012-05-14 at 23:39 +0200, Sasha Levin wrote: > On Mon, May 14, 2012 at 11:08 PM, Eric Dumazet wrote: > > Anonymous unions are fine, we use them a lot in kernel. > > While we use them a lot, we don't try initializing them that often. > > > Please fix the initializers instead in fq_codel_dump_stats(), because > > these two #define are not very nice. > > The only method I know of fixing that up is getting braces around them > in the initializer, which is hacky and will break every time a new > member is added to the struct before the anonymous union. Is there a > different solution? instead of struct foo x = { .field = value; .sub.f2 = xxx; ... }; use : struct foo x = { .field = value; }; x.sub.f2 = xxx; ... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/