Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932582Ab2ENWWd (ORCPT ); Mon, 14 May 2012 18:22:33 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:34950 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932498Ab2ENWWc convert rfc822-to-8bit (ORCPT ); Mon, 14 May 2012 18:22:32 -0400 MIME-Version: 1.0 In-Reply-To: <20120512001857.GK14782@lizard> References: <20120512001506.GA8653@lizard> <20120512001857.GK14782@lizard> Date: Mon, 14 May 2012 15:22:30 -0700 X-Google-Sender-Auth: 2DpaR7n6mfOkplojRT4jPt9MXoM Message-ID: Subject: Re: [PATCH 11/11] pstore/ram: Add ECC support From: Kees Cook To: Anton Vorontsov Cc: Greg Kroah-Hartman , Colin Cross , Arnd Bergmann , John Stultz , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2311 Lines: 64 On Fri, May 11, 2012 at 5:18 PM, Anton Vorontsov wrote: > This is now straightforward: just introduce a module parameter and pass > the needed value to persistent_ram_new(). > > Signed-off-by: Anton Vorontsov Acked-by: Kees Cook > --- > ?fs/pstore/ram.c | ? 12 +++++++++--- > ?1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c > index cf0ad92..eeb4e32 100644 > --- a/fs/pstore/ram.c > +++ b/fs/pstore/ram.c > @@ -61,6 +61,11 @@ module_param(dump_oops, int, 0600); > ?MODULE_PARM_DESC(dump_oops, > ? ? ? ? ? ? ? ?"set to 1 to dump oopses, 0 to only dump panics (default 1)"); > > +static int ramoops_ecc; > +module_param_named(ecc, ramoops_ecc, int, 0600); > +MODULE_PARM_DESC(ramoops_ecc, > + ? ? ? ? ? ? ? "set to 1 to enable ECC support"); > + > ?struct ramoops_context { > ? ? ? ?struct persistent_ram_zone **przs; > ? ? ? ?phys_addr_t phys_addr; > @@ -251,7 +256,7 @@ static int __init ramoops_probe(struct platform_device *pdev) > ? ? ? ? ? ? ? ?size_t sz = cxt->record_size; > ? ? ? ? ? ? ? ?phys_addr_t start = cxt->phys_addr + sz * i; > > - ? ? ? ? ? ? ? cxt->przs[i] = persistent_ram_new(start, sz, 0); > + ? ? ? ? ? ? ? cxt->przs[i] = persistent_ram_new(start, sz, ramoops_ecc); > ? ? ? ? ? ? ? ?if (IS_ERR(cxt->przs[i])) { > ? ? ? ? ? ? ? ? ? ? ? ?err = PTR_ERR(cxt->przs[i]); > ? ? ? ? ? ? ? ? ? ? ? ?pr_err("failed to initialize a prz\n"); > @@ -283,9 +288,10 @@ static int __init ramoops_probe(struct platform_device *pdev) > ? ? ? ?record_size = pdata->record_size; > ? ? ? ?dump_oops = pdata->dump_oops; > > - ? ? ? pr_info("attached 0x%lx@0x%llx (%ux0x%zx)\n", > + ? ? ? pr_info("attached 0x%lx@0x%llx (%ux0x%zx), ecc: %s\n", > ? ? ? ? ? ? ? ?cxt->size, (unsigned long long)cxt->phys_addr, > - ? ? ? ? ? ? ? cxt->max_count, cxt->record_size); > + ? ? ? ? ? ? ? cxt->max_count, cxt->record_size, > + ? ? ? ? ? ? ? ramoops_ecc ? "on" : "off"); > > ? ? ? ?return 0; > > -- > 1.7.9.2 -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/