Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965205Ab2EOCuv (ORCPT ); Mon, 14 May 2012 22:50:51 -0400 Received: from mail1.windriver.com ([147.11.146.13]:53401 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964873Ab2EOCRV (ORCPT ); Mon, 14 May 2012 22:17:21 -0400 From: Paul Gortmaker To: , Subject: [34-longterm 100/179] net: filter: Use WARN_RATELIMIT Date: Mon, 14 May 2012 22:13:16 -0400 Message-ID: <1337048075-6132-101-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 1.7.9.6 In-Reply-To: <1337048075-6132-1-git-send-email-paul.gortmaker@windriver.com> References: <1337048075-6132-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1468 Lines: 45 From: Joe Perches ------------------- This is a commit scheduled for the next v2.6.34 longterm release. http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git If you see a problem with using this for longterm, please comment. ------------------- commit 6c4a5cb219520c7bc937ee186ca53f03733bd09f upstream. A mis-configured filter can spam the logs with lots of stack traces. Rate-limit the warnings and add printout of the bogus filter information. Original-patch-by: Ben Greear Signed-off-by: Joe Perches Signed-off-by: David S. Miller Signed-off-by: Paul Gortmaker --- net/core/filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index 2bc5376..85d1340 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -292,7 +292,9 @@ load_b: mem[f_k] = X; continue; default: - WARN_ON(1); + WARN_RATELIMIT(1, "Unknown code:%u jt:%u tf:%u k:%u\n", + fentry->code, fentry->jt, + fentry->jf, fentry->k); return 0; } -- 1.7.9.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/