Date: Tue, 15 May 2012 09:53:38 +0200 (CEST)
From: Joel Reardon <joel@clambassador.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: determining if a block erasure failed
Message-ID: <alpine.DEB.2.00.1205150944550.17750@eristoteles.iwoars.net>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1056
Lines: 33

I want the caller of erase_worker() to be aware if the erase block became
bad. Here is the relevant code at the end of erase_worker():

/* at this time, the erase has failed. err == -EIO */
        ubi_msg("mark PEB %d as bad", pnum);
        err = ubi_io_mark_bad(ubi, pnum);
        if (err)
                goto out_ro;

/* does other stuff, not touching err */

/* err == 0 here, because of above goto */
        return err;

out_ro:
        ubi_ro_mode(ubi);
        return err;


So, if this function should return zero when the erase block fails, then I
will add a "result" field to ubi_work that will store the result of the
work function. But I figured I'd check first if the return err that always
returns 0 is not an oversight and this function should return -EIO if it
fails.

cheers,
Joel Reardon

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/