Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757138Ab2EOKAT (ORCPT ); Tue, 15 May 2012 06:00:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58892 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756864Ab2EOKAR (ORCPT ); Tue, 15 May 2012 06:00:17 -0400 Date: Tue, 15 May 2012 11:59:56 +0200 From: Jan Kara To: Wang Sheng-Hui Cc: Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext2: cleanup the comment for ext2_export_ops Message-ID: <20120515095956.GA22359@quack.suse.cz> References: <4FB0B0F4.3060908@gmail.com> <20120514095525.GD5353@quack.suse.cz> <4FB19B96.4010106@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4FB19B96.4010106@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2852 Lines: 81 On Tue 15-05-12 07:56:06, Wang Sheng-Hui wrote: > On 2012年05月14日 17:55, Jan Kara wrote: > > On Mon 14-05-12 15:15:00, Wang Sheng-Hui wrote: > >> ext2_export_ops gets more valued fields, not get_parent only. > >> Clean up the comment. > > Um, I'd just remove the whole comment. It isn't particularly informative > > anyway - NULL meaning the default behavior is very common in kernel. And we > > really set about half of entries anyway... > > > > Honza > > Thanks, Honza. > > Patch regenerated. Please check it. OK, thanks for the patch. Honza > >> Signed-off-by: Wang Sheng-Hui > >> --- > >> fs/ext2/super.c | 1 - > >> 1 files changed, 0 insertions(+), 1 deletions(-) > >> > >> diff --git a/fs/ext2/super.c b/fs/ext2/super.c > >> index e1025c7..640b4c6 100644 > >> --- a/fs/ext2/super.c > >> +++ b/fs/ext2/super.c > >> @@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, > >> /* Yes, most of these are left as NULL!! > >> * A NULL value implies the default, which works with ext2-like file > >> * systems, but can be improved upon. > >> - * Currently only get_parent is required. > >> */ > >> static const struct export_operations ext2_export_ops = { > >> .fh_to_dentry = ext2_fh_to_dentry, > >> -- > >> 1.7.1 > > From 362925f80bdfb1c105e346f535c5e51c7359b550 Mon Sep 17 00:00:00 2001 > From: Wang Sheng-Hui > Date: Tue, 15 May 2012 07:53:46 +0800 > Subject: [PATCH] ext2: remove the redundant comment for ext2_export_ops > > Per Honza, It isn't particularly informative anyway - NULL > meaning the default behavior is very common in kernel. And we > really set about half of entries anyway. > > Remove the whole comment for ext2_export_ops. > > Signed-off-by: Wang Sheng-Hui > --- > fs/ext2/super.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index e1025c7..f9b0f41 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -356,11 +356,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, > ext2_nfs_get_inode); > } > > -/* Yes, most of these are left as NULL!! > - * A NULL value implies the default, which works with ext2-like file > - * systems, but can be improved upon. > - * Currently only get_parent is required. > - */ > static const struct export_operations ext2_export_ops = { > .fh_to_dentry = ext2_fh_to_dentry, > .fh_to_parent = ext2_fh_to_parent, > -- > 1.7.1 > -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/