Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932480Ab2EOMMF (ORCPT ); Tue, 15 May 2012 08:12:05 -0400 Received: from mga11.intel.com ([192.55.52.93]:42188 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932388Ab2EOMMC (ORCPT ); Tue, 15 May 2012 08:12:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="asc'?scan'208";a="153147171" Message-ID: <1337084131.2528.189.camel@sauron.fi.intel.com> Subject: Re: [PATCH v2] UBI: add lnum to struct ubi_work From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Joel Reardon Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 15 May 2012 15:15:31 +0300 In-Reply-To: References: <1337080498.2528.161.camel@sauron.fi.intel.com> <1337081204.2528.171.camel@sauron.fi.intel.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-KiRwr6k2JqEoF9pmeWgG" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2009 Lines: 57 --=-KiRwr6k2JqEoF9pmeWgG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2012-05-15 at 13:47 +0200, Joel Reardon wrote: > For vol_id, its straightforward everywhere except: ubi_wl_init_scan() >=20 > where scheduling erase on the: >=20 > struct ubi_scan_leb *seb >=20 > appears to lack access to the volume id. Should we add vol_id to > ubi_scan_leb, and in ubi_scan() run: >=20 > ubi_rb_for_each_entry(rb1, sv, &si->volumes, rb) { > ubi_rb_for_each_entry(rb2, seb, &sv->root, u.rb) > seb->vol_id =3D sv->vol_id; >=20 > Or is there a simpler way? I guess yes. Add this field as a separate patch please. --=20 Best Regards, Artem Bityutskiy --=-KiRwr6k2JqEoF9pmeWgG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAABAgAGBQJPskjjAAoJECmIfjd9wqK0L04P/3YUCWbRk79CushnlErJeMbq cq1CFkjoHQoyN0z137GKiMrtVHn1h+V8Le+FpUjSGLOCcqqUTuv0womZdqjeoVUo KgCkgRwrKbP9pMNd+lgbwVLOh+0eDH+bCC9xFz8gLvN8Vp76/uIB84Nm/VoLOif1 1aKvcP0VtoME8zdE9CIRcXf2VRWUPe4da6koNoEK0tKrJswnfWe8tovaSm8xEChf eFHFCi6Hm+MMcQS5HfDeMe8Gvg07nRIZ1Cvh6G1HZ2lTpQ/YszHsSxPAYpVzceC4 zOgUqk6IVNc2WlJwuvNElyKD4wzN2lxlNGVdo1zvmZWAVuboUzZleSogd+3GHUxA wBlplsNh5rcpOIqdKpmHlNJl8SQvi6rAWzZkMhRd5hgodloA0lobBdLT/9ivHaDv ryT1vnHs0L3VPZF2mdzkyunBQq7I2A2KAqSbZXQPescy1VMB9upUv7KWMQ3OftMn cEsKEE0kd+bccvIpYXEtH53L1XX+XjdXED7KDTQ/b1dCcHHi1qY2BZJ+TzBdjLSi MJXB8BjE8Un0Hh2Pi3VD/vC6CoGK7wPG/WLCg/uBuea6jHorZnR1U6VljujdiBx8 Tu+l1PVFyeqTIB0Xo55ycoa/dhrF4LMwfc9xo3VUnBPbWBFuet5/i8eabI8XatjL GAYGRcZZB3UOhm3WQski =NbV2 -----END PGP SIGNATURE----- --=-KiRwr6k2JqEoF9pmeWgG-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/