Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758600Ab2EOP3z (ORCPT ); Tue, 15 May 2012 11:29:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48549 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757928Ab2EOP3y (ORCPT ); Tue, 15 May 2012 11:29:54 -0400 Date: Tue, 15 May 2012 18:29:42 +0300 From: Gleb Natapov To: Alan Cox Cc: Hannes Reinecke , LKML , "H. Peter Anvin" Subject: Re: [PATCH] EDD: Check for correct EDD 3.0 length Message-ID: <20120515152942.GH6948@redhat.com> References: <1337079889-62380-1-git-send-email-hare@suse.de> <20120515111255.GJ32036@redhat.com> <4FB23C09.7060300@suse.de> <20120515115917.GK32036@redhat.com> <20120515150015.5bf17aea@pyramind.ukuu.org.uk> <20120515143644.GD6948@redhat.com> <20120515155206.520e46b6@pyramind.ukuu.org.uk> <20120515145316.GF6948@redhat.com> <20120515162226.1b9a7496@pyramind.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120515162226.1b9a7496@pyramind.ukuu.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 36 On Tue, May 15, 2012 at 04:22:26PM +0100, Alan Cox wrote: > On Tue, 15 May 2012 17:53:16 +0300 > Gleb Natapov wrote: > > > On Tue, May 15, 2012 at 03:52:06PM +0100, Alan Cox wrote: > > > > It is easy to be confused since there are two EDD 3 specs. First is from > > > > Phoenix BIOS (linked at the first mail of the thread) and it does not have > > > > enough info even for ATA. You can't tell primary ATA controller from secondary. > > > > > > Yes you can - it's defined by the PCI specification for compatibility > > How? ATA device path has only Master/Slave. Interface path has only > > bus/slot/function. So given all that in int13_80 how do I know if this > > is primary or secondary controller? > > For compatibility mode by the I/O port address. > Hmm, will work if standard I/O addresses are used for master/slave, but I do not see this information be exposed via /sys by EDD. So how can I do it from OS installer with current kernel or kernel with reverted patch? > For native mode most controllers pretend to be two devfns for exactly > this reason, and report one on each. Some non-MMIO devices don't and you > can tell them apart by looking at the addresses given in DPTE as well. > > Simples.. > > Alan -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/