Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759000Ab2EOQmj (ORCPT ); Tue, 15 May 2012 12:42:39 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:14750 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753132Ab2EOQmh (ORCPT ); Tue, 15 May 2012 12:42:37 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6712"; a="188861928" Message-ID: <4FB2875C.6030402@codeaurora.org> Date: Tue, 15 May 2012 09:42:04 -0700 From: Saravana Kannan User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Sascha Hauer CC: "Turquette, Mike" , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, rnayak@ti.com Subject: Re: [PATCH] clk: Constify struct clk_init_data References: <1337004763-21250-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20120514215304.GB3075@gmail.com> <4FB1AF14.3050507@codeaurora.org> <20120515070058.GK30400@pengutronix.de> In-Reply-To: <20120515070058.GK30400@pengutronix.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1753 Lines: 46 On 05/15/2012 12:00 AM, Sascha Hauer wrote: > On Mon, May 14, 2012 at 06:19:16PM -0700, Saravana Kannan wrote: >> On 05/14/2012 02:53 PM, Turquette, Mike wrote: >>> On Mon, May 14, 2012 at 7:12 AM, Mark Brown wrote: >>>> Allow drivers to declare their clk_init_data const, the framework really >>>> shouldn't be modifying the data. >>>> >>>> Signed-off-by: Mark Brown >>> >>> +interested parties >>> >>>> >>>> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h >>>> index c1c23b9..fc43ea6 100644 >>>> --- a/include/linux/clk-provider.h >>>> +++ b/include/linux/clk-provider.h >>>> @@ -143,7 +143,7 @@ struct clk_init_data { >>>> */ >>>> struct clk_hw { >>>> struct clk *clk; >>>> - struct clk_init_data *init; >>>> + const struct clk_init_data *init; >> >> Oh, wait. This won't work for the case where the clock registration >> is completely dynamic. Say, created from device tree or thru some >> PCI/USB device probe, etc. That's why I didn't add it before. > > Why not? In this case clk_init_data is also only used in clk_register. > Given that Mark has posted the patch I assume it actually works. > > Sascha > It's used in __clk_register() though. Which I added as a "as close as clk_register() but allows static init" function. -Saravana -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/