Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966371Ab2EOSlS (ORCPT ); Tue, 15 May 2012 14:41:18 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:58960 "EHLO e28smtp02.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933288Ab2EOSkx (ORCPT ); Tue, 15 May 2012 14:40:53 -0400 Message-ID: <4FB2A2F3.40101@linux.vnet.ibm.com> Date: Wed, 16 May 2012 00:09:47 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120424 Thunderbird/12.0 MIME-Version: 1.0 To: Linus Torvalds CC: John David Anglin , "akpm@linux-foundation.org" , Ingo Molnar , Peter Zijlstra , Mikulas Patocka , stepanm@codeaurora.org, Thomas Gleixner , James.Bottomley@hansenpartnership.com, deller@gmx.de, dhowells@redhat.com, yasutake.koichi@jp.panasonic.com, eike-kernel@sf-tec.de, linux-parisc@vger.kernel.org, "linux-kernel@vger.kernel.org" , tobiasu@tmux.org Subject: Re: Linux 3.4-rc7 References: <4FB011E7.1000604@linux.vnet.ibm.com> <4FB0197F.6010000@linux.vnet.ibm.com> <4FB2A090.6060404@linux.vnet.ibm.com> In-Reply-To: <4FB2A090.6060404@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit x-cbid: 12051518-5816-0000-0000-0000029F8612 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2170 Lines: 79 On 05/15/2012 11:59 PM, Srivatsa S. Bhat wrote: > On 05/15/2012 10:54 PM, Linus Torvalds wrote: > >> On Sun, May 13, 2012 at 5:42 PM, John David Anglin wrote: >>> >>> I successfully booted 3.4-rc7 with this change on rp3440 (4 cpu smp). My >>> build also >>> included cache and other fixes that are being discussed on the parisc list. >> >> Can somebody send the final patches with proper subject lines etc, >> instead of hiding them in unrelated threads? I hate picking up patches >> that I don't personally know from the middle of some random thread. >> > > > Okay, here they are: > This one is for mn10300: --- From: Srivatsa S. Bhat Subject: [PATCH] mn10300/CPU hotplug: Add missing call to notify_cpu_starting() The scheduler depends on receiving the CPU_STARTING notification, without which we end up into a lot of trouble. So add the missing call to notify_cpu_starting() in the bringup code. Signed-off-by: Srivatsa S. Bhat --- arch/mn10300/kernel/smp.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/mn10300/kernel/smp.c b/arch/mn10300/kernel/smp.c index 910dddf..9cd69ad 100644 --- a/arch/mn10300/kernel/smp.c +++ b/arch/mn10300/kernel/smp.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -38,7 +39,6 @@ #include "internal.h" #ifdef CONFIG_HOTPLUG_CPU -#include #include static unsigned long sleep_mode[NR_CPUS]; @@ -874,10 +874,13 @@ static void __init smp_online(void) cpu = smp_processor_id(); - local_irq_enable(); + notify_cpu_starting(cpu); + ipi_call_lock(); set_cpu_online(cpu, true); - smp_wmb(); + ipi_call_unlock(); + + local_irq_enable(); } /** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/