Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966797Ab2EOUxt (ORCPT ); Tue, 15 May 2012 16:53:49 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:59802 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966555Ab2EOUxr (ORCPT ); Tue, 15 May 2012 16:53:47 -0400 Date: Tue, 15 May 2012 13:53:30 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Konstantin Khlebnikov cc: Andrew Morton , KAMEZAWA Hiroyuki , Johannes Weiner , Michal Hocko , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] mm/memcg: apply add/del_page to lruvec In-Reply-To: <4FB21988.40503@openvz.org> Message-ID: References: <4FB0E985.9000107@openvz.org> <4FB21988.40503@openvz.org> User-Agent: Alpine 2.00 (LSU 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1482 Lines: 34 On Tue, 15 May 2012, Konstantin Khlebnikov wrote: > Hugh Dickins wrote: > > > > I had been hoping to get this stage, where I think we're still in > > agreement (except perhaps on the ordering of function arguments!), > > into 3.5 as a basis for later discussion. > > Yeah, my version differs mostly in function's names and ordering of > arguments. > I use 'long' for last argument in mem_cgroup_update_lru_size(), > and call it once in isolate_lru_pages(), rather than for each isolated page. That sounds very sensible, now that lumpy isn't switching lruvecs: can be done alongside the similarly deferred __mod_zone_page_state()s. > You have single mem_cgroup_page_lruvec() variant, and this is biggest > difference > between our versions. So, Ok, nothing important at this stage. > > Acked-by: Konstantin Khlebnikov Thanks a lot, I appreciate you going back to delve in, despite being put off by appearances earlier. Yes, I'm only dealing with the trivial passing down of lruvec instead of zone here, where I felt we'd be sure to more or less agree. It seemed the right follow-on to your lruvec work in vmscan.c, giving us both a good base in 3.5-rc1 on which to try out our more interesting bits. Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/