Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967143Ab2EPAU5 (ORCPT ); Tue, 15 May 2012 20:20:57 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:53962 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966737Ab2EPAUz convert rfc822-to-8bit (ORCPT ); Tue, 15 May 2012 20:20:55 -0400 MIME-Version: 1.0 In-Reply-To: <1337013111-7732-1-git-send-email-tartler@cs.fau.de> References: <1337013111-7732-1-git-send-email-tartler@cs.fau.de> From: Eric Miao Date: Wed, 16 May 2012 08:20:31 +0800 Message-ID: Subject: Re: [PATCH] mbxfb: unbreak compilation with CONFIG_FB_MBX_DEBUG To: tartler@cs.fau.de Cc: Florian Tobias Schandinat , Arnd Bergmann , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, vamos-dev@lists.cs.fau.de, Reinhard Tartler Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 44 On Tue, May 15, 2012 at 12:31 AM, wrote: > From: Reinhard Tartler > > This patch adds missing function prototypes. > > Signed-off-by: Reinhard Tartler > --- >  drivers/video/mbx/mbxfb.c |    3 +++ >  1 file changed, 3 insertions(+) > > This patch was found with tools developed in the VAMOS project: > http://www4.cs.fau.de/Research/VAMOS/ > > TBH, I'm not sure if this is the correct solution. However, I'd > appreciate if someone could confirm that this is a real bug. This looks to be a correct solution to me. Acked-by: Eric Miao > > > diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c > index 6ce3416..c2200ec 100644 > --- a/drivers/video/mbx/mbxfb.c > +++ b/drivers/video/mbx/mbxfb.c > @@ -878,6 +878,9 @@ static int mbxfb_resume(struct platform_device *dev) >  #ifndef CONFIG_FB_MBX_DEBUG >  #define mbxfb_debugfs_init(x)  do {} while(0) >  #define mbxfb_debugfs_remove(x)        do {} while(0) > +#else > +void mbxfb_debugfs_init(struct fb_info *fbi); > +void mbxfb_debugfs_remove(struct fb_info *fbi); >  #endif > >  #define res_size(_r) (((_r)->end - (_r)->start) + 1) > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/