Message-ID: <1337132987.7050.29.camel@joe2Laptop>
Subject: Re: [PATCH net-next 2/2] net: ipv4 and ipv6: Convert
 printk(KERN_DEBUG to pr_debug
From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David S. Miller" <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        James Morris <jmorris@namei.org>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Patrick McHardy <kaber@trash.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Tue, 15 May 2012 18:49:47 -0700
In-Reply-To: <20120515183536.2cac1e29@nehalam.linuxnetplumber.net>
References: <cover.1337126962.git.joe@perches.com>
	 <1fd8285e798ec9b3817c790a67b2bb655ffc931b.1337126963.git.joe@perches.com>
	 <20120515183536.2cac1e29@nehalam.linuxnetplumber.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1051
Lines: 30

On Tue, 2012-05-15 at 18:35 -0700, Stephen Hemminger wrote:
> On Tue, 15 May 2012 17:11:54 -0700
> Joe Perches <joe@perches.com> wrote:
> 
> > Use the current debugging style and enable dynamic_debug.
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> 
> This changes the action of the system. By default:
>   printk(KERN_DEBUG "foo\n");
> is enabled all the time and prints to log with debug level.
> 
> But your version
>   pr_debug("foo\n");
> defaults to being dropped until the system is built with dynamic
> debug, and that particular debug instance is enabled.
> 
> Since these are all useful, but low priority messages, not I
> don't think disabling them by default is such a great idea now.

Just had that discussion with David Miller.

http://marc.info/?l=linux-sctp&m=133710673230503&w=2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/