Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759530Ab2EPHad (ORCPT ); Wed, 16 May 2012 03:30:33 -0400 Received: from mail-qa0-f49.google.com ([209.85.216.49]:57244 "EHLO mail-qa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759223Ab2EPHab convert rfc822-to-8bit (ORCPT ); Wed, 16 May 2012 03:30:31 -0400 MIME-Version: 1.0 In-Reply-To: References: <1336798797-8724-1-git-send-email-skannan@codeaurora.org> Date: Wed, 16 May 2012 09:30:30 +0200 Message-ID: Subject: Re: [PATCH] clk: Fix race conditions between clk_set_parent() and clk_enable() From: Linus Walleij To: "Turquette, Mike" Cc: Saravana Kannan , Arnd Bergman , linux-arm-kernel@lists.infradead.org, Andrew Lunn , Paul Walmsley , Russell King , Linus Walleij , Stephen Boyd , linux-arm-msm@vger.kernel.org, Sascha Hauer , Mark Brown , Magnus Damm , linux-kernel@vger.kernel.org, Rob Herring , Richard Zhao , Grant Likely , Deepak Saxena , Amit Kucheria , Jamie Iles , Jeremy Kerr , Thomas Gleixner , Shawn Guo Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 19 On Wed, May 16, 2012 at 8:00 AM, Turquette, Mike wrote: > The above hunk is a good change since it fixes a bug where we > prepare/enable the parent clocks around the .set_parent callback, even > when CLK_SET_PARENT_GATE is set. ?It should be a separate patch. This makes me think that maybe some of these clk fixes really need to add Cc: stable@kernel.org so they get into 3.4 as well. Not that there are plenty of in-kernel users, but since people may be basing development off the 3.4 tree, it would be good to have fixes propagate there. Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/