Message-ID: <4FB3702A.3040900@redhat.com>
Date: Wed, 16 May 2012 12:15:22 +0300
From: Avi Kivity <avi@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1
MIME-Version: 1.0
To: Xudong Hao <xudong.hao@linux.intel.com>
CC: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, haitao.shan@intel.com,
        xiantao.zhang@intel.com, xudong.hao@intel.com
Subject: Re: [PATCH 2/4] Add parameter to control A/D bits support
References: <20120516010818.GC14256@hp-xd.sh.intel.com>
In-Reply-To: <20120516010818.GC14256@hp-xd.sh.intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1150
Lines: 32

On 05/16/2012 04:08 AM, Xudong Hao wrote:
> Add kernel parameter to control A/D bits support, it's on by default.
>
> Signed-off-by: Haitao Shan <haitao.shan@intel.com>
> Signed-off-by: Xudong Hao <xudong.hao@intel.com>
>
> ---
>  arch/x86/kvm/vmx.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index d2bd719..811a61e 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -64,6 +64,9 @@ static bool __read_mostly enable_unrestricted_guest = 1;
>  module_param_named(unrestricted_guest,
>             enable_unrestricted_guest, bool, S_IRUGO);
>
> +static int __read_mostly enable_ept_ad_bits = 1;
> +module_param_named(ept_ad_bits, enable_ept_ad_bits, bool, S_IRUGO);

Please use bool.  And call the external name 'eptad', for easier use.


-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/