From: Arnd Bergmann <arnd@arndb.de>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] driver: char: bfin_crc: CRC hardware accelerator driver for BF60x family processors.
Date: Wed, 16 May 2012 15:11:26 +0000
User-Agent: KMail/1.12.2 (Linux/3.4.0-rc3; KDE/4.3.2; x86_64; ; )
Cc: sonic.zhang@analog.com, LKML <linux-kernel@vger.kernel.org>,
        uclinux-dist-devel@blackfin.uclinux.org
References: <1337156767-13232-1-git-send-email-sonic.zhang@analog.com> <201205161339.41736.arnd@arndb.de> <20120516145333.GB1139@kroah.com>
In-Reply-To: <20120516145333.GB1139@kroah.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201205161511.27232.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1350
Lines: 32

On Wednesday 16 May 2012, Greg Kroah-Hartman wrote:
> > Do we have a userspace crypto API these days? The last I remember every
> > attempt to add one so far was abandoned before it got merged. There is
> > drivers/s390/crypto/zcrypt*, which has a nonportable API, and 
> > then there is the in-kernel crypto layer in drivers/crypto that has
> > no user interface at all.
> 
> What is CONFIG_CRYPTO_USER for then, with the matching,
> crypto/crypto_user.c file?

Ah, I completely missed that going in and looked in the wrong place
when trying to find it now (/drivers/crypto, not /crypto). I'm glad
that part is resolved.

> > I agree that having another private driver for bfin_crc is not a good
> > idea, but I also don't have a better one.
> > 
> > About the driver itself, the submission seems incomplete (missing at
> > least the bfin_crc.h file) and the driver has a number of shortcomings
> > that we should discuss in case we decide to merge it.
> 
> I suggest at least tieing into the in-kernel crypto api first, and then
> worrying about the userspace side of things, right?

Absolutely.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/