Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756294Ab2EPP7h (ORCPT ); Wed, 16 May 2012 11:59:37 -0400 Received: from mga07.intel.com ([143.182.124.22]:23550 "EHLO azsmga101.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755950Ab2EPP7e convert rfc822-to-8bit (ORCPT ); Wed, 16 May 2012 11:59:34 -0400 MIME-Version: 1.0 In-Reply-To: <1337179563.2985.80.camel@dabdike.int.hansenpartnership.com> References: <1337157034-22773-1-git-send-email-geert@linux-m68k.org> <1337179563.2985.80.camel@dabdike.int.hansenpartnership.com> Date: Wed, 16 May 2012 18:59:33 +0300 Message-ID: Subject: Re: Build regressions/improvements in v3.4-rc7 From: "Kasatkin, Dmitry" To: James Bottomley Cc: Geert Uytterhoeven , linux-kernel@vger.kernel.org, Linuxppc-dev , Parisc List , "the arch/x86 maintainers" , James Morris Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1906 Lines: 44 On Wed, May 16, 2012 at 5:46 PM, James Bottomley wrote: > On Wed, 2012-05-16 at 10:47 +0200, Geert Uytterhoeven wrote: >> On Wed, May 16, 2012 at 10:30 AM, Geert Uytterhoeven >> wrote: >>   + lib/mpi/generic_mpih-mul1.c: error: inconsistent operand >> constraints in an 'asm':  => 50:70 >>   + lib/mpi/generic_mpih-mul2.c: error: inconsistent operand >> constraints in an 'asm':  => 49:70 >>   + lib/mpi/generic_mpih-mul3.c: error: inconsistent operand >> constraints in an 'asm':  => 49:70 >>   + lib/mpi/mpih-div.c: error: inconsistent operand constraints in an >> 'asm':  => 135:122, 135:371, 97:122, 106:121, 106:370, 97:371 >> >> parisc-allmodconfig > > Wow, lib/mpi/ is a complete horror: it's full of hand crafted asm code. > The error in this case appears to be that umul_ppm() is implemented as > an xmpyu instruction.  That's a floating point instruction.  We > deliberately compile the kernel with floating point disabled because we > don't want to save and restore the floating point register file on each > context switch, hence the operand constraints are unsatisfiable. > > It appears to be completely untested on non-x86 and to have been > imported via the security tree ... what are we supposed to do with this? > I thought the general principle was that asm code was really supposed to > be confined to the arch directories? > > James > > Yes.. it is suxx. But it is only longlong.h and inherited from gpg.. And now there is a stuff such as /include/math-emu/soft-fp and I planned to look to that but now I will start doing it right away. - Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/