MIME-Version: 1.0
In-Reply-To: <20120516125634.GB20475@lizard>
References: <20120516125330.GA15460@lizard>
	<20120516125634.GB20475@lizard>
Date: Wed, 16 May 2012 09:45:35 -0700
Message-ID: <CAGXu5jKiq-OhCMjf+PkEgyYi3wC3bTR=0nL-FacXDBnOpFZJ5A@mail.gmail.com>
Subject: Re: [PATCH 2/6] pstore/ram: Add console messages handling
From: Kees Cook <keescook@chromium.org>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
        Arnd Bergmann <arnd@arndb.de>, John Stultz <john.stultz@linaro.org>,
        Shuah Khan <shuahkhan@gmail.com>, arve@android.com,
        Rebecca Schultz Zavin <rebecca@android.com>,
        Jesper Juhl <jj@chaosbits.net>, Randy Dunlap <rdunlap@xenotime.net>,
        Stephen Boyd <sboyd@codeaurora.org>, Thomas Meyer <thomas@m3y3r.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Marco Stornelli <marco.stornelli@gmail.com>,
        WANG Cong <xiyou.wangcong@gmail.com>, linux-kernel@vger.kernel.org,
        devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org,
        patches@linaro.org, kernel-team@android.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1503
Lines: 43

On Wed, May 16, 2012 at 5:56 AM, Anton Vorontsov
<anton.vorontsov@linaro.org> wrote:
> This is all straightforward: we just use the last region for
> console logging. If there's just one region, we fall-back to
> the old behaviour: just a oops/dumps logging.
>
> Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
> ---
> ?fs/pstore/ram.c | ? 39 ++++++++++++++++++++++++++++++---------
> ?1 file changed, 30 insertions(+), 9 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 9123cce..54213eb 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> [...]
> @@ -142,7 +148,12 @@ static int ramoops_pstore_write(enum pstore_type_id type,
> ? ? ? ?struct persistent_ram_zone *prz = cxt->przs[cxt->count];
> ? ? ? ?size_t hlen;
>
> - ? ? ? /* Currently ramoops is designed to only store dmesg dumps. */
> + ? ? ? if (type == PSTORE_TYPE_CONSOLE) {
> + ? ? ? ? ? ? ? if (!cxt->cprz)
> + ? ? ? ? ? ? ? ? ? ? ? return -ENOMEM;
> + ? ? ? ? ? ? ? persistent_ram_write(cxt->cprz, cxt->pstore.buf, size);
> + ? ? ? }
> +
> ? ? ? ?if (type != PSTORE_TYPE_DMESG)
> ? ? ? ? ? ? ? ?return -EINVAL;

Doesn't this mean that type == PSTORE_TYPE_CONSOLE will write to the
ram, but then fail with -EINVAL?

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/