Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965336Ab2EPTrw (ORCPT ); Wed, 16 May 2012 15:47:52 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:32995 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965259Ab2EPTrt convert rfc822-to-8bit (ORCPT ); Wed, 16 May 2012 15:47:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <20120516170124.GA21275@google.com> From: Linus Torvalds Date: Wed, 16 May 2012 12:47:27 -0700 X-Google-Sender-Auth: 8vtPVFeT6lDAM60ILDHYIi844Q8 Message-ID: Subject: Re: [PATCH] floppy: convert to delayed work and single-thread wq To: Jiri Kosina Cc: Stephen Hemminger , Tejun Heo , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 566 Lines: 15 On Wed, May 16, 2012 at 12:37 PM, Jiri Kosina wrote: > + ? ? ? cancel_delayed_work_sync(&fd_timeout); > + ? ? ? cancel_delayed_work_sync(&fd_timer); > + ? ? ? destroy_workqueue(system_nrt_wq); Well, *that* doesn't look right. I think just a "flush_workqueue()" is in order. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/