Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760618Ab2EPUBy (ORCPT ); Wed, 16 May 2012 16:01:54 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:37194 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760081Ab2EPUBw (ORCPT ); Wed, 16 May 2012 16:01:52 -0400 Date: Wed, 16 May 2012 13:01:47 -0700 From: Tejun Heo To: Jiri Kosina Cc: Linus Torvalds , Stephen Hemminger , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] floppy: convert to delayed work and single-thread wq Message-ID: <20120516200147.GD21275@google.com> References: <20120516170124.GA21275@google.com> <20120516195332.GC21275@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 30 On Wed, May 16, 2012 at 09:57:22PM +0200, Jiri Kosina wrote: > On Wed, 16 May 2012, Tejun Heo wrote: > > > > On Wed, May 16, 2012 at 12:37 PM, Jiri Kosina wrote: > > > > + ? ? ? cancel_delayed_work_sync(&fd_timeout); > > > > + ? ? ? cancel_delayed_work_sync(&fd_timer); > > > > + ? ? ? destroy_workqueue(system_nrt_wq); > > > > > > Well, *that* doesn't look right. > > > > > > I think just a "flush_workqueue()" is in order. > > > > System wqs shouldn't be flushed (nothing guarantees that flush will > > finish in fixed amount of time). We probably should make that > > explicit by whining when someone tries to flush one of the system wqs. > > Here, the two cancel_delayed_work_sync() calls should be enough. > > Well, then I think this might be an issue for straightforward conversion > of floppy driver to system_nrt_wq -- see floppy_grab_irq_and_dma(). Hmmm? flush_work() is fine. flush_workqueue() isn't. Am I missing something? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/