Date: Wed, 16 May 2012 15:11:43 -0700
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Colin Cross <ccross@android.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kees Cook <keescook@chromium.org>, Tony Luck <tony.luck@intel.com>,
        Arnd Bergmann <arnd@arndb.de>, John Stultz <john.stultz@linaro.org>,
        Shuah Khan <shuahkhan@gmail.com>, arve@android.com,
        Rebecca Schultz Zavin <rebecca@android.com>,
        Jesper Juhl <jj@chaosbits.net>, Randy Dunlap <rdunlap@xenotime.net>,
        Stephen Boyd <sboyd@codeaurora.org>, Thomas Meyer <thomas@m3y3r.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Marco Stornelli <marco.stornelli@gmail.com>,
        WANG Cong <xiyou.wangcong@gmail.com>, linux-kernel@vger.kernel.org,
        devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org,
        patches@linaro.org, kernel-team@android.com
Subject: Re: [PATCH 4/6] pstore/ram: Add some more documentation and examples
Message-ID: <20120516221143.GA20576@lizard>
References: <20120516125330.GA15460@lizard>
 <20120516125658.GD20475@lizard>
 <CAMbhsRRmcaS7W-eY2eiiBa6xeAeeG+t5Bj4yVmKqkiFbs1bV3Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAMbhsRRmcaS7W-eY2eiiBa6xeAeeG+t5Bj4yVmKqkiFbs1bV3Q@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1074
Lines: 26

On Wed, May 16, 2012 at 10:56:09AM -0700, Colin Cross wrote:
[...]
> > +You can specify either RAM memory or peripheral devices' memory. However, when
> > +specifying RAM, be sure to reserve the memory by issuing memblock_reserve()
> > +very early in the architecture code, just before platform device registration,
> 
> Just before platform device registration is way too late.  ARM
> provides a machine reserve callback to allow board files to call
> memblock_reserve inside arm_memblock_init() and before mm_init().

Yeah, and I guess that 'too late' is also true for all architectures,
the platform_device_register and friends are most probably unusable
before mm_init, and after that it's always too late.

So the word 'just' is misleading indeed, I'll remove it.

Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/