Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759798Ab2EPWZV (ORCPT ); Wed, 16 May 2012 18:25:21 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:61227 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757406Ab2EPWZT convert rfc822-to-8bit (ORCPT ); Wed, 16 May 2012 18:25:19 -0400 MIME-Version: 1.0 In-Reply-To: <20120516221143.GA20576@lizard> References: <20120516125330.GA15460@lizard> <20120516125658.GD20475@lizard> <20120516221143.GA20576@lizard> Date: Wed, 16 May 2012 15:25:17 -0700 X-Google-Sender-Auth: r_wa7l3tKmEmc_BuQOemyU4HxA4 Message-ID: Subject: Re: [PATCH 4/6] pstore/ram: Add some more documentation and examples From: Colin Cross To: Anton Vorontsov Cc: Greg Kroah-Hartman , Kees Cook , Tony Luck , Arnd Bergmann , John Stultz , Shuah Khan , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1337 Lines: 26 On Wed, May 16, 2012 at 3:11 PM, Anton Vorontsov wrote: > On Wed, May 16, 2012 at 10:56:09AM -0700, Colin Cross wrote: > [...] >> > +You can specify either RAM memory or peripheral devices' memory. However, when >> > +specifying RAM, be sure to reserve the memory by issuing memblock_reserve() >> > +very early in the architecture code, just before platform device registration, >> >> Just before platform device registration is way too late. ?ARM >> provides a machine reserve callback to allow board files to call >> memblock_reserve inside arm_memblock_init() and before mm_init(). > > Yeah, and I guess that 'too late' is also true for all architectures, > the platform_device_register and friends are most probably unusable > before mm_init, and after that it's always too late. > > So the word 'just' is misleading indeed, I'll remove it. I think any reference to the time when platform devices are registered is misleading. There is a very specific point during arch init where memblock_reserve is valid, and it is nowhere near platform device registration. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/