Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759609Ab2EQGoJ (ORCPT ); Thu, 17 May 2012 02:44:09 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:53842 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759137Ab2EQGoI (ORCPT ); Thu, 17 May 2012 02:44:08 -0400 Message-ID: <4FB49E74.8030409@mev.co.uk> Date: Thu, 17 May 2012 07:45:08 +0100 From: Ian Abbott Organization: MEV Ltd User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: H Hartley Sweeten CC: Greg KH , Linux Kernel , "devel@driverdev.osuosl.org" , "fmhess@users.sourceforge.net" , Ian Abbott Subject: Re: [PATCH] staging: comedi: Convert struct addi_board initialization to C99 format References: <201205161751.56913.hartleys@visionengravers.com>,<20120517021805.GA32592@kroah.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 31 On 17/05/12 07:15, H Hartley Sweeten wrote: > Wednesday, May 16, 2012 7:18 PM, Greg KH wrote: >> On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote: >>> Convert the struct addi_board initialization to C99 format and remove >>> all the NULL or 0 initializers. This makes maintaining and editing the >>> code simpler and less error prone. >> Nice job, this driver is a pain to read... > > Thanks. I agree... I've been avoiding the addi drivers until now. > Anytime a C file has an #include "something.c" it makes me > shudder... > > I've been thinking that the addi stuff should really be broken up > into some library modules with exported symbols for the individual > addi drivers to use. I need to look a bit closer at them to see if > this would work. Right now the whole thing is a bit of a mess. TBH, I don't know how they got accepted into Comedi in the first place. They tend to do their own thing as far as comedi instruction handling goes. I've no idea who's using them. It makes me shudder, too! Did I mention the use of floating point in some of their drivers that we had to disable? -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/