Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761254Ab2EQHZP (ORCPT ); Thu, 17 May 2012 03:25:15 -0400 Received: from linux-sh.org ([111.68.239.195]:60632 "EHLO linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761075Ab2EQHZM (ORCPT ); Thu, 17 May 2012 03:25:12 -0400 Date: Thu, 17 May 2012 16:24:50 +0900 From: Paul Mundt To: Magnus Damm Cc: linux-kernel@vger.kernel.org, rjw@sisk.pl, linus.walleij@stericsson.com, arnd@arndb.de, linux-sh@vger.kernel.org, horms@verge.net.au, grant.likely@secretlab.ca, olof@lixom.net Subject: Re: [PATCH][RESEND] gpio: Emma Mobile GPIO driver V2 Message-ID: <20120517072450.GC11623@linux-sh.org> References: <20120517062223.1314.98945.sendpatchset@w520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120517062223.1314.98945.sendpatchset@w520> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 36 On Thu, May 17, 2012 at 03:22:23PM +0900, Magnus Damm wrote: > From: Magnus Damm > > This patch is V2 of the Emma Mobile GPIO driver. This > driver is designed to be reusable between multiple SoCs > that share the same basic building block, but so far it > has only been used on Emma Mobile EV2. > > Each driver instance handles 32 GPIOs with individually > maskable IRQs. The driver operates on two I/O memory > ranges and the 32 GPIOs are hooked up to two interrupts. > > In the case of Emma Mobile EV2 this GPIO building block > is used as main external interrupt controller hooking up > 159 GPIOS as 159 interrupts via 5 driver instances and > 10 interrupts to the GIC and the Cortex-A9 Dual. > > Signed-off-by: Magnus Damm > Acked-by: Linus Walleij > --- > > Rafael, can you please pick up? > > Changes since V1: > - use inline for private data functions using container_of() > - use BIT(n) instead of 1 << n > - added legacy irq domain support for static mappings My distaste for arbitrary static mappings aside, it makes no sense to support this as a module if the irq domain can't be cleaned up at present. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/