Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761618Ab2EQKv1 (ORCPT ); Thu, 17 May 2012 06:51:27 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:52816 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712Ab2EQKvZ convert rfc822-to-8bit (ORCPT ); Thu, 17 May 2012 06:51:25 -0400 MIME-Version: 1.0 In-Reply-To: References: <1337152826-9850-1-git-send-email-sonic.zhang@analog.com> <1337152826-9850-3-git-send-email-sonic.zhang@analog.com> Date: Thu, 17 May 2012 16:21:24 +0530 Message-ID: Subject: Re: [PATCH 3/8] i2c: i2c-bfin-twi: Break dead waiting loop if i2c device misbehaves. From: Shubhrajyoti Datta To: Mike Frysinger Cc: sonic.zhang@analog.com, Ben Dooks , Wolfram Sang , linux-i2c@vger.kernel.org, LKML , uclinux-dist-devel@blackfin.uclinux.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 22 On Thu, May 17, 2012 at 10:53 AM, Mike Frysinger wrote: > On Thu, May 17, 2012 at 1:20 AM, Shubhrajyoti Datta > wrote: >> On Wed, May 16, 2012 at 12:50 PM, ? wrote: >>> From: Sonic Zhang >>> >>> Some fault i2c device may hold the sda/scl line and cause i2c driver >>> wait in the BUS busy loop. This patch breaks this potential dead >>> loop. >> >> How about using a non-busy loop while you are at it. > > the timings here are fairly small ... OK no issues. Anyways was just a suggestion.:-) > -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/