Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933361Ab2EQPGt (ORCPT ); Thu, 17 May 2012 11:06:49 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34434 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933033Ab2EQPGs (ORCPT ); Thu, 17 May 2012 11:06:48 -0400 Date: Thu, 17 May 2012 17:06:41 +0200 (CEST) From: Jiri Kosina To: Tejun Heo Cc: Linus Torvalds , Stephen Hemminger , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] floppy: convert to delayed work and single-thread wq In-Reply-To: <20120517145519.GF21275@google.com> Message-ID: References: <20120516170124.GA21275@google.com> <20120516195332.GC21275@google.com> <20120516200147.GD21275@google.com> <20120516202924.GE21275@google.com> <20120517145519.GF21275@google.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 762 Lines: 24 On Thu, 17 May 2012, Tejun Heo wrote: > > Umm. If there are abritrarily long things and these are serialized, > > then that workqueue is not good for putting floppy work on it either, > > is it? I don't think you can have it both ways. > > They're not being serialized. Then it's useless for this very purpose -- the sole purpose of the floppy_wq having as a single-threaded wq is to run all the work serialized. So the patch I have sent out this morning is the way to go. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/