Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933434Ab2EQPJb (ORCPT ); Thu, 17 May 2012 11:09:31 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:60382 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933404Ab2EQPJ2 (ORCPT ); Thu, 17 May 2012 11:09:28 -0400 Date: Thu, 17 May 2012 08:09:23 -0700 From: Tejun Heo To: Jiri Kosina Cc: Linus Torvalds , Stephen Hemminger , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] floppy: convert to delayed work and single-thread wq Message-ID: <20120517150923.GH21275@google.com> References: <20120516195332.GC21275@google.com> <20120516200147.GD21275@google.com> <20120516202924.GE21275@google.com> <20120517145519.GF21275@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 28 On Thu, May 17, 2012 at 05:06:41PM +0200, Jiri Kosina wrote: > On Thu, 17 May 2012, Tejun Heo wrote: > > > > Umm. If there are abritrarily long things and these are serialized, > > > then that workqueue is not good for putting floppy work on it either, > > > is it? I don't think you can have it both ways. > > > > They're not being serialized. > > Then it's useless for this very purpose -- the sole purpose of the > floppy_wq having as a single-threaded wq is to run all the work > serialized. > > So the patch I have sent out this morning is the way to go. Yeah, that seems to be my confusion here - I thought serialization is necessary only for a work item. Can you please use alloc_ordered_workqueue() instead of create_singlethread_workqueue()? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/