Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762324Ab2EQS2Y (ORCPT ); Thu, 17 May 2012 14:28:24 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:53089 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762167Ab2EQS2W (ORCPT ); Thu, 17 May 2012 14:28:22 -0400 MIME-Version: 1.0 In-Reply-To: <20120517084042.GB31753@lizard> References: <20120517083740.GA25627@lizard> <20120517084042.GB31753@lizard> Date: Thu, 17 May 2012 11:28:22 -0700 X-Google-Sender-Auth: DC5HVyMXUaTrA0S0j_fDWWDkDVE Message-ID: Subject: Re: [PATCH 2/6] pstore/ram: Add console messages handling From: Colin Cross To: Anton Vorontsov Cc: Greg Kroah-Hartman , Kees Cook , Tony Luck , Arnd Bergmann , John Stultz , Shuah Khan , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 17 On Thu, May 17, 2012 at 1:40 AM, Anton Vorontsov wrote: > This is all straightforward: we just use the last region for > console logging. If there's just one region, we fall-back to > the old behaviour: just a oops/dumps logging. > > Signed-off-by: Anton Vorontsov I don't think using the last region is the right way to handle this. We often use very large regions for ramconsole, up to 2MB. Using a single region would require a 2MB region for console and a 2MB region for oops, which is far too large. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/