Message-ID: <1337289897.8872.8.camel@joe2Laptop>
Subject: Re: [PATCH 1/1] checkpatch: don't fake typedefs with #define
From: Joe Perches <joe@perches.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: linux-kernel@vger.kernel.org, apw@canonical.com
Date: Thu, 17 May 2012 14:24:57 -0700
In-Reply-To: <20120517211641.GC27953@pcarmody2.research.nokia.com>
References: <1337259132-28774-1-git-send-email-ext-phil.2.carmody@nokia.com>
	 <1337288048.17726.64.camel@joe2Laptop>
	 <20120517211641.GC27953@pcarmody2.research.nokia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1004
Lines: 30

On Fri, 2012-05-18 at 00:16 +0300, Phil Carmody wrote:
> On 17/05/12 13:54 -0700, ext Joe Perches wrote:
> > > +# check for deliberate avoidance of the above anti-typedef rule
> > > +		if ($line =~ /#\s*define\s+$Ident\s+$Type\b/) {
> > > +			WARN("NEW_TYPEDEFS",
> > > +			     "do not fake typedefs using #define\n" . $herecurr);
> > > +		}
> > > +
> > 
> > I think the false positive rate is pretty high.
> > I used this and don't see too many I'd remove.
> > 
> > $ git grep -E "#\s*define\s+\w+\s+(struct|unsigned|char|short|int|long|const)\b"
> > 
> > Got an example you want this to find?
> 
> Too many. Alas I can't share them.

Too bad.

If all the defines end in _t maybe you could use
	if ($line =~ /^\+\s*#\s*define\s+\w+_t\s+$Type\b/) {
etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/